Exclude (not set) city and country from reports. #9943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for cf5d2f9 have been deleted. |
|
Size Change: -4 B (0%) Total Size: 1.98 MB
ℹ️ View Unchanged
|
techanvil
requested changes
Jan 2, 2025
assets/js/modules/analytics-4/components/widgets/TopCitiesWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCountriesWidget.js
Outdated
Show resolved
Hide resolved
ankitrox
force-pushed
the
enhancement/7884-remove-not-set-key-metrics
branch
from
aa8171d to
a4cdb3a
Compare
techanvil
requested changes
Jan 3, 2025
assets/js/modules/analytics-4/components/widgets/TopCitiesWidget.js
Outdated
Show resolved
Hide resolved
|
Thank you @techanvil . I have created a separated utility function so that we can use it in both places. Also added tests for the function. |
techanvil
requested changes
Jan 6, 2025
| @@ -0,0 +1,25 @@ | |||
| /** | |||
| * Analytics 4 filter rows having (not set) values. | |||
There was a problem hiding this comment.
Let's tweak the description to be a bit clearer:
Suggested change
| * Analytics 4 filter rows having (not set) values. | |
| * Utility to filter out Analytics report rows which don't have a value set. |
Comment on lines
2
to
4
| * Analytics-4 filter rows having (not set) values tests. | ||
| * | ||
| * Site Kit by Google, Copyright 2022 Google LLC |
There was a problem hiding this comment.
As above, and also fix the date:
Suggested change
| * Analytics-4 filter rows having (not set) values tests. | |
| * | |
| * Site Kit by Google, Copyright 2022 Google LLC | |
| * Tests for utility to filter out Analytics report rows which don't have a value set. | |
| * | |
| * Site Kit by Google, Copyright 2024 Google LLC |
Comment on lines
22
to
28
| const mockRows = [ | ||
| { dimensionValues: [ { value: 'value1' } ] }, | ||
| { dimensionValues: [ { value: '(not set)' } ] }, | ||
| { dimensionValues: [ { value: 'value2' } ] }, | ||
| { dimensionValues: [ { value: 'value3' } ] }, | ||
| { dimensionValues: [ { value: 'value4' } ] }, | ||
| ]; |
There was a problem hiding this comment.
Let's define this in a beforeEach() to make the tests more robust. As things stand, if we consider reportRowsWithSetValues() as a black box, it could in theory mutate this data structure between tests.
Suggested change
| const mockRows = [ | |
| { dimensionValues: [ { value: 'value1' } ] }, | |
| { dimensionValues: [ { value: '(not set)' } ] }, | |
| { dimensionValues: [ { value: 'value2' } ] }, | |
| { dimensionValues: [ { value: 'value3' } ] }, | |
| { dimensionValues: [ { value: 'value4' } ] }, | |
| ]; | |
| let mockRows; | |
| beforeEach( () => { | |
| mockRows = [ | |
| { dimensionValues: [ { value: 'value1' } ] }, | |
| { dimensionValues: [ { value: '(not set)' } ] }, | |
| { dimensionValues: [ { value: 'value2' } ] }, | |
| { dimensionValues: [ { value: 'value3' } ] }, | |
| { dimensionValues: [ { value: 'value4' } ] }, | |
| ]; | |
| } ); |
|
Thanks for reviewing the PR @techanvil . I've updated the PR as per your suggestions and assigning it to you for reviewing the changes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist